refactor: use require for testing errors #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
approved these changes
Apr 6, 2023
pd93
force-pushed
the
use-require-for-test-errors
branch
from
ce3dc98 to
87393c2
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
github.com/stretchr/testify/requireto test errors instead ofgithub.com/stretchr/testify/assert. This applies to bothNoErrorandErrorfunctions.This means that execution of the test will stop if we get an into an unexpected state and it will stop further cascading error assertions from obscuring the root cause.
The
assertpackage is still used everywhere else as this means that we can see when multiple values are incorrect if the test is in a "good" state.