fix: status-checks should respect task and global silent-mode #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
reviewed
Apr 6, 2023
| @@ -141,7 +141,7 @@ func (e *Executor) RunTask(ctx context.Context, call taskfile.Call) error { | |||
| } | |||
|
|
|||
| if upToDate && preCondMet { | |||
| if !e.Silent { | |||
| if e.Verbose || (!t.Silent && !e.Taskfile.Silent && !e.Silent) { | |||
There was a problem hiding this comment.
I see this was already being respected for the --silent, but not for the Taskfile or task level attribute.
One more reason to proceed in name of consistency. 🙁
|
Thanks for contributing @danquah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #546 this pull-request updates the condition surrounding the "up to date" message emitted from the status-check to now also respect the task-level silence flag. It also allows the user to switch off silence via the Verbose flag.
I view this more as a fix than a new feature so I have not added any documentation. I'll be happy to do so if it is deemd nessecary.