Implemented dry run mode #126
Conversation
Added a --dry-run flag that compiles and steps through each task, but does not execute them. The commands that would have been run are printed. See go-task#125.
There was a problem hiding this comment.
Hey @bebbs, thank for the pull request!
What about calling it --dry instead of --dry-run?
A simple test for it would be nice, but if you don't want to write it, I can do that after merging this PR
Note to myself: in the future we should disallow some flags to be used together, like --silent and --dry or --silent and --verbose (not in this PR)
README.md
Outdated
| ## Dry Run Mode | ||
|
|
||
| Dry run mode (`--dry-run`) compiles and steps through each task, printing the commands | ||
| that would be run without executing them. This is useful for debugging your Taskfiles. |
There was a problem hiding this comment.
👍 for adding documentation for it
completion/zsh/_task
Outdated
| @@ -12,6 +12,7 @@ function __list() { | |||
|
|
|||
| _arguments \ | |||
| '(-d --dir)'{-d,--dir}': :_files' \ | |||
| '(--dry-run)'--dry-run \ | |||
There was a problem hiding this comment.
👍 for remembering to update this file
|
No problem! Done. I couldn't see where to add tests for the effects of flags, apologies if I've missed it. Agree it would be nice to have them, happy for you to merge and add the test if you'd prefer, or let me know where you would like to see one and I'll add it to this PR? |
|
Indeed there's no test for flags currently, but we can have a test on Optional in your part, but you can do if you're feeling adventurous 🙂 |
|
All done @andreynering, I've added a test case that would touch a file, checks that the task is compiled without errors, and checks that the file does not exist after running. |
|
@bebbs Great! Thanks again for the contribution I'll do very small changes after merging |
Added a --dry-run flag that compiles and steps through each task, but does not execute them. The commands that would have been run are printed. See #125.