Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong working directory with USER_WORKING_DIR in included Taskfi… #1274

Closed
wants to merge 1 commit into from

Conversation

andarto
Copy link

@andarto andarto commented Jul 21, 2023

…les (#1250)

When using dir: '{{.USER_WORKING_DIR}}' in an included task, the working directory was set incorrectly by concatenating the base Taskfile directory and the USER_WORKING_DIR.

#1205 might be the same problem and is possibly fixed too, but I haven't tested the patch on Windows.

Also, while this patch fixes the symptom, there a better place to implement the fix would be where the USER_WORKING_DIR gets concatenated in the first place, but I wasn't able the find that in the time a had available. At least this patch and the included test case should point you in the right direction.

…les (go-task#1250)

When using `dir: '{{.USER_WORKING_DIR}}'` in an included task, the working
directory was set incorrectly by concatenating the base Taskfile directory
and the USER_WORKING_DIR.
andreynering added a commit that referenced this pull request Aug 18, 2023
andreynering added a commit that referenced this pull request Aug 18, 2023
Closes #1046
Closes #1205
Closes #1250
Closes #1293
Closes #1274
Closes #1309

Co-authored-by: Marcus Spading <ms@fragmentum.net>
@andreynering andreynering added the area: variables Changes related to variables. label Aug 18, 2023
@andreynering
Copy link
Member

Hi @andarto,

Thanks for your contribution!

I have done changes to this fix and opened #1309, so I'm closing this one.

andreynering added a commit that referenced this pull request Aug 26, 2023
Closes #1046
Closes #1205
Closes #1250
Closes #1293
Closes #1274
Closes #1309
Closes #1312

Co-authored-by: Marcus Spading <ms@fragmentum.net>
andreynering added a commit that referenced this pull request Aug 26, 2023
Closes #1046
Closes #1205
Closes #1250
Closes #1293
Closes #1274
Closes #1309
Closes #1312

Co-authored-by: Marcus Spading <ms@fragmentum.net>
andreynering added a commit that referenced this pull request Aug 26, 2023
Closes #1046
Closes #1205
Closes #1250
Closes #1293
Closes #1274
Closes #1309
Closes #1312

Co-authored-by: Marcus Spading <ms@fragmentum.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: variables Changes related to variables.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants