Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add new job to check if versioned_docs has been modified #1719

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

vmaerten
Copy link
Member

@vmaerten vmaerten commented Jul 9, 2024

A small proposal: check in the CI if files under versioned_docs has been modified.

We had the issue twice (#1669 && #1673) so I think doing this check in the CI can be useful
EDIT : this one too : #1702
Here is what it looks like :

image

I've put it under lint because I did not want to create another workflow file

@vmaerten vmaerten requested review from andreynering and pd93 July 9, 2024 18:53
@vmaerten vmaerten changed the title ci: add new workflow to check if versioned_docs has been modified ci: add new job to check if versioned_docs has been modified Jul 9, 2024
Copy link
Member

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good idea. Thanks for catching the problem in those PRs. Are there any docs changes that have been overridden as a result of this?

@vmaerten
Copy link
Member Author

@pd93 AFAIK, only for #1669, I made the change in #1717 (and @andreynering merged it)

@pd93 pd93 merged commit 9d72fa3 into go-task:main Jul 16, 2024
14 checks passed
pd93 added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants