fix(completion): display aliases in fish completion

[vmaerten]

Fixes #1781

Before :

After :

@davinkevin It would be amazing if you could test it before we release this. I test it locally with the docker container it sounds fine

[davinkevin]

I have the same result as you and it looks good to me!

I was surprised the completion was displayed like this, but it works like expected 😇

PS: I hope those completions will, one day, be part of the product and not volatile scripts maintained aside from the source code.

[davinkevin]

Interesting 🤔

with this file:

version: 3

tasks:

  aaa:
    aliases:
      - bbb
      - ccc
      - ddd
    cmd: echo aaa

  bbb2: echo bbb2
  ccc: echo ccc

The completion choose bbb2 if I type task b + tab, instead of asking to choose between bbb2 and bbb. We use the "description" field of fish to display aliases, but it's some kind of useless, a description would be better 😇.

wdyt?

[pd93]

Happy with this as a fix, but I think it would be good to move this complexity to Task itself sometime rather than relying on invoking sed. Looking at this expression gives me a headache 😆

[davinkevin]

Definitive +1!

It would be simpler and more powerful. To match my previous comment, I had to do something like this:

set -l output (echo $rawOutput | sed -e '1d; s/\* \(.*\):\s*\(.*\)\s*(aliases: \(.*\))/\1,\3/' -e 's/\* \(.*\):\s*\(.*\)/\1\t\2/' -e 's@,@\n@g' -e 's@ @@g'| string split0)

The result is better than the original version, but doing that with a real language is the best solution/idea!

[vmaerten]

I totally agree with you, I would even argue that fish / bash / zsh does not support the same "feature" in the auto complete
As you said, we could move all complexity in our go code

[vmaerten]

I've tested it in zsh, the behavior is the same, aliases are displayed but not "searchable"

[pd93]

PS: I hope those completions will, one day, be part of the product and not volatile scripts maintained aside from the source code.

For the record. I just merged #1157 which is the first step towards this. We can now start the process of generating the scripts instead of using the templates.

[vmaerten]

@pd93 What do you think about merging this to have  the same behavior as zsh, and, in the meantime, working on generating the scripts in golang ?

[pd93]

What do you think about merging this to have  the same behavior as zsh, and, in the meantime, working on generating the scripts in golang ?

@vmaerten Yeah I'm fine with this. This change is still an improvement, even if there are still bigger changes to come.