Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interpolate vars in defer #1814

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

vmaerten
Copy link
Member

@vmaerten vmaerten commented Sep 18, 2024

Fixes #1803

@andreynering I am not sure about this part.

If it does not look good, feel free to re-do it from scratch

@vmaerten vmaerten marked this pull request as ready for review September 18, 2024 14:44
Co-authored-by: Andrey Nering <andreynering@users.noreply.github.com>
@andreynering andreynering merged commit 1bf8505 into main Sep 19, 2024
14 checks passed
@andreynering andreynering deleted the 1803/fix-use-var-in-defer branch September 19, 2024 01:17
@andreynering
Copy link
Member

@vmaerten Thanks! I just pushed a change to make the e.GetTask(call) call more scoped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3.39.0] defer no longer evaluates variables
2 participants