Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add linter misspell #1883

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

christiandins
Copy link
Contributor

  • find commonly misspelled english words

The past participle for "override" is "overridden", both in American and in British English:
https://www.oxfordlearnersdictionaries.com/definition/english/override?q=override

@christiandins christiandins changed the title added linter misspell feat: added linter misspell Oct 25, 2024
Copy link
Member

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of opinionated style changes in here. Are you using a tool to do this or are they manually changed? I'm not a fan of merging style changes without an agreed upon tool/standard because everyone has an opinion and code tends to flip between styles in PRs unnecessarily.

My assumption is that the changes are based on line length, but its not clear what the rules are or whether they have been applied everywhere or just the files you're changing.

@christiandins
Copy link
Contributor Author

Hi, I’m using https://github.com/segmentio/golines, which runs automatically every time I save a file. You’re absolutely right that these are unnecessary changes, and I’ll revert them accordingly. However, I can definitely recommend golines for improved readability! :)

- find commonly misspelled english words
@christiandins christiandins force-pushed the feat/add-linter-misspell branch from c9020b4 to cb3760d Compare October 26, 2024 16:22
@vmaerten vmaerten self-requested a review November 15, 2024 20:45
@vmaerten vmaerten changed the title feat: added linter misspell chore: added linter misspell Nov 15, 2024
@vmaerten vmaerten changed the title chore: added linter misspell chore: add linter misspell Nov 15, 2024
@vmaerten vmaerten merged commit 8a79a41 into go-task:main Nov 15, 2024
14 checks passed
vmaerten added a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants