Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include taskfile vars in task scope #416

Closed
wants to merge 1 commit into from

Conversation

zlesnr
Copy link

@zlesnr zlesnr commented Dec 9, 2020

Without this change, the variables present on a Taskfile are not available from
within the Task. This means that in the case of a "Live" variable, the task
template is unable to access these objects as expected.

Here we merge the Taskfile vars into the vars for the given Task, allowing the
Live variables to be accessed from within the Task template scope.

Without this change, the variables present on a Taskfile are not available from
within the Task.  This means that in the case of a "Live" variable, the task
template is unable to access these objects as expected.

Here we merge the Taskfile vars into the vars for the given Task, allowing the
Live variables to be accessed from within the Task template scope.
@zlesnr
Copy link
Author

zlesnr commented Dec 9, 2020

Related to #121

@zlesnr
Copy link
Author

zlesnr commented Dec 9, 2020

It seems that this is breaking the tests. I've also tried the merge the other direction, starting with the Taskfile vars and then merging in the specific Task vars, which also fails the tests. Is there another way to approach this? I was digging around in the code to see how I could get access to the Taskfile Vars from within the task itself, but it looks like only the environment variable are cared for. Guidance here would be appreciated.

@andreynering
Copy link
Member

Hi @zlesnr,

It's not clear to me what exactly you're trying to fix here. Do you mind sharing an example Taskfile showing the issue?

@andreynering
Copy link
Member

Closing for lack of feedback (and I still did not understand the intention, as mentioned before).

Feel free to comment if you still think there is something to be fixed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants