Attempt to fix Task not following symlinks #831
Conversation
ilewin
force-pushed
the
check_path_for_symlinks_issue_826
branch
from
5e32164
to
98ba3fd
Compare
There was a problem hiding this comment.
Hi @ilewin,
Given there's an issue open on mvdan/sh#843, I think we should not try to fix it when running shell commands and wait for a fix upstream.
Let's code the fix for the source calculation only.
Regarding the PR itself, please write a meaningful commit message and be careful with unnecessary changes to the codebase like changing new lines, commented code, etc (specially on files you didn't change). The diff should be on relevant code only.
internal/status/glob.go
Outdated
| //fs, err := zglob.Glob(g) //Looks like this does not evaluate **/* glob correctly | ||
| fs, err := filepath.Glob(g) |
There was a problem hiding this comment.
filepath.Glob does not support double star (foo/**/*.js). We should keep using zglob.Glob
There was a problem hiding this comment.
Ok, Thanks I will dig more.
Zglob does not follow symlinks so I will try to figure out how to have both ** and symlinks
mattn/go-zglob#3
ilewin
force-pushed
the
check_path_for_symlinks_issue_826
branch
from
98ba3fd
to
6e18872
Compare
…o evaluate symlinks
ilewin
force-pushed
the
check_path_for_symlinks_issue_826
branch
from
6e18872
to
2a67499
Compare
andreynering
added
the
type: enhancement
|
Thanks @ilewin! |
Please check if this could be a good solution for the described bug.