fix: ignore empty dotfile file names #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #858 - A bug (introduced in f45dd11) that causes an "is a directory" error when a taskfile contains a
dotfileskey with unresolved variable.The bug exists because the new
e.setCurrentDir()function is settinge.Dirto the taskfile's root directory where it was previously"". When this variable was empty and the given dotfile was also empty,os.Statwould have returned anos.ErrNotExistand the loop would havecontinued. However, now thate.Diris set to the taskfile directory, thisos.Stat()check passes (as the directory exists) and thegodotenv.Read()function errors causing the program to fail.This fix simply checks if each value in the list of
dotfilesis empty (not set) andcontinuesif it is. This allows users to continue using the behaviour described in #858 where they could conditionally set environment variables via thedotfileskey.