Suggest the most similar task name when a given task does not exist #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpushka
force-pushed
the
feat/suggest-similar-task
branch
from
0a642ab
to
402832a
Compare
andreynering
reviewed
Oct 7, 2022
There was a problem hiding this comment.
Hi @maxpushka, thanks for working on this PR!
I made a few comments, but once addressed this is good to be merged.
Can you also squash all your commits and keep a single one? Thanks!
maxpushka
force-pushed
the
feat/suggest-similar-task
branch
5 times, most recently
from
17c787b
to
9c59c84
Compare
maxpushka
force-pushed
the
feat/suggest-similar-task
branch
from
9c59c84
to
3e5ee23
Compare
|
Hi @andreynering, thank you for the suggestions! A simpler error struct is the thing I should have gone on with from the start |
|
Thanks @maxpushka! Merged with small changes, including training the model with the aliases as well, now that they are available on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #867.
If the fuzzy model fails to find the most similar task name, it will just say "task does not exist" and the suggestion message won't be shown