Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961.
This problem occurs when a user uses
version: '2'
in their Taskfile in combination with aTaskfile_{{OS}}.yml
file. In the case of #961, I'm guessing there was only aTaskfile_windows.yml
file which is why the issue doesn't repro on Linux.This happens because the
Merge
function is called withincludedTaskfile
set tonil
:task/taskfile/read/taskfile.go
Lines 171 to 182 in 5be1f6b
This value is then not being nil checked in the
Merge
function here:task/taskfile/merge.go
Line 48 in 5be1f6b
The fix simply adds a nil check to this line.