Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interface for file data #469

Merged
merged 5 commits into from
Nov 8, 2021
Merged

Create interface for file data #469

merged 5 commits into from
Nov 8, 2021

Conversation

Syfaro
Copy link
Member

@Syfaro Syfaro commented Aug 20, 2021

This reworks the library's file handling to use a new interface for file data instead of relying on magic types and interfaces. This should also allow for users to implement the same methods for arbitrary external types to make uploads easier.

It introduces one breaking change (as far as I know) where strings to local file paths are no longer allowed.

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #469 (d2539d0) into develop (309d612) will decrease coverage by 0.48%.
The diff coverage is 48.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #469      +/-   ##
===========================================
- Coverage    49.10%   48.62%   -0.49%     
===========================================
  Files            7        7              
  Lines         1507     1487      -20     
===========================================
- Hits           740      723      -17     
+ Misses         716      706      -10     
- Partials        51       58       +7     
Impacted Files Coverage Δ
helpers.go 58.20% <ø> (ø)
types.go 75.92% <ø> (ø)
bot.go 39.46% <46.15%> (-0.91%) ⬇️
configs.go 43.60% <48.64%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309d612...d2539d0. Read the comment docs.

@Syfaro Syfaro marked this pull request as ready for review October 6, 2021 14:09
@Syfaro Syfaro merged commit 7c82078 into develop Nov 8, 2021
@Syfaro Syfaro deleted the files branch November 8, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant