Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and grammar issues in comments #483

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Fix typos and grammar issues in comments #483

merged 1 commit into from
Nov 8, 2021

Conversation

alexandear
Copy link
Contributor

This PR fixes issues in comments:

  • Typos in words.
  • Use a comma before 'so' if it connects two independent clauses (unless they are closely connected and short). 
  • This word is normally spelled with a hyphen.
  • Use a comma before 'or' if it connects two independent clauses (unless they are closely connected and short). 
  • Use an instead of 'a' if the following word starts with a vowel sound, e.g. 'an article', 'an hour'. 
  • Did you mean past? 
  • Consider using either the past participle filed or the present participle filing here. 
  • Consider using many. 
  • When '64-bit' is used as a modifier, it is usually spelled with a hyphen. 
  • The past participle is required after "must be", alternatively you could omit the "be". 

Copy link
Member

@Syfaro Syfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, I think there's one thing that wasn't quite correct.

I also quite substantially updated the master branch, so it might take a little bit of messing around to get it into a state where it can be merged again, sorry!

params.go Outdated Show resolved Hide resolved
@alexandear
Copy link
Contributor Author

@Syfaro I updated PR, please recheck

Copy link
Member

@Syfaro Syfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Syfaro Syfaro merged commit 8999cea into go-telegram-bot-api:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants