feat: reset sequences in one exec #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it faster
|
@slsyy 🚀 |
wxiaoguang
reviewed
Oct 31, 2024
| if _, err := db.Exec(fmt.Sprintf("ALTER TABLE %s AUTO_INCREMENT = %d", h.quoteKeyword(t), resetSequencesTo)); err != nil { | ||
| return err | ||
| } | ||
| b.WriteString(fmt.Sprintf("ALTER TABLE %s AUTO_INCREMENT = %d;", h.quoteKeyword(t), resetSequencesTo)) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
This seems to cause failures when using testfixtures with mysql: |
slsyy
added a commit
to slsyy/testfixtures
that referenced
this pull request
Dec 22, 2024
The go-testfixtures#208 PR introduced an optimisation, which requires the `multiStatements=true` parameter in connection string to work properly It looks like that the requirement for that parameter (which is stated in `README.md`) was not honored by users (e.g go-testfixtures#240), so I want to keep the old behavior for convienience This commit: * remove mention about parameter requirement from `README.md` * revert default to `one query per one statement` * allows to keep `one query per multiple statements` logic with a `testfixtures.AllowMultipleStatementsInOneQuery` flag * some tests for both use cases
slsyy
added a commit
to slsyy/testfixtures
that referenced
this pull request
Dec 22, 2024
The go-testfixtures#208 PR introduced an optimisation, which requires the `multiStatements=true` parameter in connection string to work properly It looks like that the requirement for that parameter (which is stated in `README.md`) was not honored by users (e.g go-testfixtures#240), so I want to keep the old behavior for convenience This commit: * remove mention about parameter requirement from `README.md` * revert default to `one query per one statement` * allows to keep `one query per multiple statements` logic with a `testfixtures.AllowMultipleStatementsInOneQuery` flag * some tests for both use cases
slsyy
added a commit
that referenced
this pull request
Dec 22, 2024
The #208 PR introduced an optimisation, which requires the `multiStatements=true` parameter in connection string to work properly It looks like that the requirement for that parameter (which is stated in `README.md`) was not honored by users (e.g #240), so I want to keep the old behavior for convenience This commit: * remove mention about parameter requirement from `README.md` * revert default to `one query per one statement` * allows to keep `one query per multiple statements` logic with a `testfixtures.AllowMultipleStatementsInOneQuery` flag * some tests for both use cases
|
@kolaente Fixed in #249 , released in https://github.com/go-testfixtures/testfixtures/releases/tag/v3.14.0 |
|
Seems to work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make it faster