This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
feat: call build specific runtime functions #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
changed the title
Runtime.SetupBuild and Runtime.AssembleBuild
But it doesn't print anything for docker runtime which doesn't need it.
cognifloyd
force-pushed
the
k8s-post-assemble-build
branch
from
2d84251 to
59449bd
Compare
Many of the env vars added in PlanStep ae not available in Kubernetes because the env is immutable after pod creation. So, to make these vars available, we inject as many as possible in the CreateStep stage. STEP_STATUS and STEP_STARTED don't make sense in CreateStep, however, so we leave those out. They will just be empty for pipelines that get run by the kubernetes runtime.
So it is not an empty string. STEP_BUILD_STATUS and STEP_BUILD_STARTED cannot be populated until after the build has started (the pod exists in k8s) when each step starts. But env vars can't be updated after pod creation, so those will always show up as STEP_BUILD_STATUS=pending and STEP_BUILD_STARTED=0 to containers.
|
Please see go-vela/pkg-runtime#148 (comment) for more details on the |
cognifloyd
changed the title
Runtime.SetupBuild and Runtime.AssembleBuild
cognifloyd
commented
Oct 25, 2021
|
go-vela/pkg-runtime#148 was merged, so this is ready for review. |
jbrockopp
suggested changes
Oct 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
- Coverage 80.49% 79.82% -0.67%
==========================================
Files 31 31
Lines 2768 2825 +57
==========================================
+ Hits 2228 2255 +27
- Misses 451 473 +22
- Partials 89 97 +8
|
jbrockopp
suggested changes
Oct 25, 2021
There was a problem hiding this comment.
Looks like the validate workflow is still failing:
https://github.com/go-vela/pkg-executor/runs/4001465504?check_suite_focus=true
If you can't see that link, I believe the issue is with the deps in the go.sum file.
To resolve this, you can run a make clean 👍
jbrockopp
suggested changes
Oct 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kubernetes native secrets and a variety of
VELA_variables do not get populated in the pod environment.This was happening because container environment is immutable after pod creation. So, we need to run
Runtime.SetupContainerfor all containers before we create the pod in kubernetes. Then, we have to movecontainer.Envinitialization to just before pod creation, so that all of the vars that get populated AFTERSetupContainermake it to the container.So, I added 4 methods to the
Runtimeengine interface:SetupBuildAssembleBuildRemoveBuildInspectBuildThis allows us to manage the pod at the build level instead of using heuristics to try and manage creating/removing the pod in the container management functions.
Requires: