Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Fix the problem with lost omitted columns when performing Omit.Insert(array ...) #1146

Closed
wants to merge 1 commit into from
Closed

Fix the problem with lost omitted columns when performing Omit.Insert(array ...) #1146

wants to merge 1 commit into from

Conversation

BetaCat0
Copy link
Member

fix #1143

@BetaCat0 BetaCat0 mentioned this pull request Nov 13, 2018
Closed
@codecov-io
Copy link

codecov-io commented Nov 13, 2018 •
edited
Loading

Codecov Report

Merging #1146 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
+ Coverage   54.69%   54.77%   +0.07%     
==========================================
  Files          42       42              
  Lines        7646     7655       +9     
==========================================
+ Hits         4182     4193      +11     
+ Misses       2935     2934       -1     
+ Partials      529      528       -1
Impacted Files Coverage Δ
session_insert.go 61.84% <100%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07c406...6b3b187. Read the comment docs.

@BetaCat0 BetaCat0 changed the title fix https://github.com/go-xorm/xorm/issues/1143 Fix the problem with lost omitted columns when performing Omit.Insert(array ...) Nov 13, 2018
@BetaCat0
Copy link
Member Author

I think it's just a temporary solution for this problem, whereas we should dive into the function resetStatement and generalize to other batch operations.

lunny
lunny suggested changes Jan 21, 2019
View reviewed changes
session_insert_test.go

check := func() {
var ls []TestMultiOmit
err := testEngine.NewSession().Find(&ls)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NewSession should be closed

@lunny
Copy link
Member

lunny commented Jan 21, 2019

Please resolve conflict.

@lunny lunny mentioned this pull request Sep 27, 2019
Merged
@lunny lunny closed this Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

批量Insert时Omit出错
3 participants
@BetaCat0 @codecov-io @lunny