Add support for alternative timestamp formats #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaml.org describes several alternative formats for timestamps not covered by the default implementation of `time.UnmarshalText()`. These are handled explicitly in this change in resolve.go Timestamps will only be collected if there is an explicit timestamp tag (ie, not `!!str`) or if implicit type detection is enabled.
Factor the timestamp parsing into its own function that
can easily be changed later to support the full range of
time stamps and add a quick early check to avoid
going through all the time.Parse calls in this common
path.
Also fix marshaling so that times are still printed unquoted.
For backwards compatibility, when timestamps are unmarshaled
into interface{} values, we unmarshal them as strings.
We also make it possible to unmarshal any value that implements
TextUnmarshaler, regardless of any explicit or implicit tag.
rogpeppe
force-pushed
the
018-timestamps
branch
from
bce5d64
to
1f2a25b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This is a duplicate of #273 but applied against the devel branch and
with a few other fixes applied]
yaml.org describes several alternative formats for timestamps not
covered by the default implementation of time.UnmarshalText(). A subset
of these is covered by this PR - future work can enable full
support for all formats.
Timestamps will only be collected if there is an explicit timestamp
tag (ie, not !!str) or if implicit type detection is enabled.
This PR builds on @anthonybishopric's foundations
(see PR #117).