v3: Enabled shallow merge when unmarshal to struct. #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattaldenshaw
changed the title
|
As we discussed on the call, the proper solution to this problem is to make the decoder behave correctly per the specification and the other popular parsers, all the time. Decoding a document containing a merge should be no different than decoding a simpler document that results from the merge operations themselves, for all purposes. I believe I've addressed that in 539c8e7. Please let me know if you see any issues there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a flag called "shallowMerge" in the decoder to force the merge to be shallow when unmarshalling from yaml to struct. It will fix issue #818 @niemeyer