-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy flow files so that the module returns typed values #51
Changes from 8 commits
5d9b61e
8c260c1
a438c56
ca4ec40
d4b9340
b9360fa
d6c9d0d
cb8cb1e
82c1933
2760ed1
cfc83bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,12 +38,12 @@ export type CommitDescriptor = {| | |
|
||
export type BranchDescriptor = {| | ||
...ObjectDescriptor, | ||
sha: $PropertyType<ObjectDescriptor, "sha"> | "latest" | ||
sha: $PropertyType<ObjectDescriptor, "sha"> | ||
|}; | ||
|
||
export type FileDescriptor = {| | ||
...ObjectDescriptor, | ||
sha: $PropertyType<ObjectDescriptor, "sha"> | "latest", | ||
sha: $PropertyType<ObjectDescriptor, "sha">, | ||
fileId: string | ||
|}; | ||
|
||
|
@@ -55,7 +55,7 @@ export type PageDescriptor = {| | |
|
||
export type LayerDescriptor = {| | ||
...ObjectDescriptor, | ||
sha: $PropertyType<ObjectDescriptor, "sha"> | "latest", | ||
sha: $PropertyType<ObjectDescriptor, "sha">, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
fileId: string, | ||
pageId: string, | ||
layerId: string | ||
|
@@ -327,7 +327,7 @@ export type User = { | |
|
||
export type Organization = { | ||
billingEmail?: string, | ||
features: {[feature: string]: boolean}, | ||
features: { [feature: string]: boolean }, | ||
hasBillingInfo?: boolean, | ||
id: string, | ||
isUsernameOrganization?: boolean, | ||
|
@@ -1300,7 +1300,9 @@ export interface AbstractInterface { | |
}; | ||
|
||
organizations?: { | ||
info: (organizationDescriptor: OrganizationDescriptor) => Promise<Organization>, | ||
info: ( | ||
organizationDescriptor: OrganizationDescriptor | ||
) => Promise<Organization>, | ||
list: () => Promise<Organization[]> | ||
}; | ||
|
||
|
@@ -1391,15 +1393,15 @@ export interface AbstractInterface { | |
objectDescriptor?: OrganizationDescriptor, | ||
options?: ListOptions | ||
) => CursorPromise<Notification[]>, | ||
info: (notificationDescriptor: NotificationDescriptor) => Promise<Notification> | ||
info: ( | ||
notificationDescriptor: NotificationDescriptor | ||
) => Promise<Notification> | ||
}; | ||
|
||
users?: { | ||
list: ( | ||
objectDescriptor: OrganizationDescriptor | ProjectDescriptor | ||
) => Promise<User[]>, | ||
info: ( | ||
userDescriptor: UserDescriptor | ||
) => Promise<User> | ||
info: (userDescriptor: UserDescriptor) => Promise<User> | ||
}; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we export some/all of these types in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to switch the order of these so the babel options like
--watch
can still be used with buildThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also nit: ./src ./lib to match all the other relative paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. We'd probably want a kind of
watch
command to do both of these things, wouldn't we?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea something like that or like
start
for development