switch to chi router in weather example #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 43 43
Lines 2338 2338
=======================================
Hits 2204 2204
Misses 98 98
Partials 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raphael
reviewed
Sep 29, 2023
| @@ -73,7 +73,7 @@ func main() { | |||
| // 3. Setup metrics | |||
| ctx = metrics.Context(ctx, genfront.ServiceName, | |||
| metrics.WithRouteResolver(func(r *http.Request) string { | |||
| return httptreemux.ContextRoute(r.Context()) | |||
| return chi.RouteContext(r.Context()).RoutePattern() | |||
There was a problem hiding this comment.
This actually does not work in the general case: the chi context gets initialized after this runs. Instead the code needs to be mux.ResolvePattern(r): the Goa mux will initialize the chi route context if not initialized already.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of Goa v3.13.0, the default router was switched to
chi(Ref: goadesign/goa#3346)This PR updates the weather example to use chi.