Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Modualize the samples so that they can be gonew #131

Closed
ikawaha opened this issue Oct 7, 2023 · 7 comments
Closed

Proposal: Modualize the samples so that they can be gonew #131

ikawaha opened this issue Oct 7, 2023 · 7 comments

Comments

@ikawaha
Copy link
Contributor

ikawaha commented Oct 7, 2023

Proposal

I thought it would be good to be able to use goa examples with gonew to make it easier to run examples.

see. https://go.dev/blog/gonew

gonew goa.design/examples/basic@latest github.com/ikawaha/calc example

PoC

github.com/ikawaha/examples has a modularized version.

gonew github.com/ikawaha/examples/basic@latest github.com/<your_repo>/calc <your_dir>

You can try it like this.

Draft

Draft PR: #130

note: The tracing sample could not be modularized until it is released because it depends on the base module included in this repository. I hope to work on it later.

@raphael
Copy link
Member

raphael commented Oct 13, 2023

This is a great idea! We will want to document that in the top level README so people know to take advantage of it. I took a look at the PR and it looks great. Let me know how I can help to move this along :)

@ikawaha
Copy link
Contributor Author

ikawaha commented Oct 14, 2023

Thank you for the positive feedback! I'm pleased that the proposal resonates with you. I've already included the necessary updates to the top-level README in the current PR #130. If there are any additional modifications or specific points you'd like to address, please let me know.

Thanks again for your support!

@ikawaha
Copy link
Contributor Author

ikawaha commented Oct 14, 2023

P.S. I've worked on this as part of Hacktoberfest. If you find the contributions fitting, would you be open to adding the hacktoberfest-accepted label to this PR or the hacktoberfest topic to the repository?
Thanks!

@raphael
Copy link
Member

raphael commented Oct 14, 2023

Of course! I added the hacktoberfest topic to the repo. I have also been using the clue weather example quite a bit as a good reference for setting up Goa projects. I think it should be usable as is for gonew, maybe we also add a mention to that in the README?

@ikawaha
Copy link
Contributor Author

ikawaha commented Oct 14, 2023

I've updated the README for our Goa Examples repository. I've added information about the Goa Clue example and mentioned the use of the gonew command for easy cloning. d9ffbdc

If you have any feedback or suggestions, please let me know.

Thanks,

@ikawaha
Copy link
Contributor Author

ikawaha commented Oct 27, 2023

All tasks related to the proposal have been successfully completed. Closing this issue. Thank you for the valuable input and collaboration!

@ikawaha ikawaha closed this as completed Oct 27, 2023
@raphael
Copy link
Member

raphael commented Oct 27, 2023

Thank you for the great contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants