Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tracing example #137

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

ikawaha
Copy link
Contributor

@ikawaha ikawaha commented Oct 15, 2023

issue: #131

see. #130

In continuation from our previous PR (#130), where we addressed certain build issues and streamlined the repository structure, this PR introduces the tracing sample. This sample was separated out to ensure a smoother build process and better clarity.

As discussed, we opted to separate the tracing sample to avoid complications arising from the replace directive. Now that the main repository changes are in place, we believe this sample can be safely merged without any build or dependency issues.

@ikawaha ikawaha marked this pull request as ready for review October 15, 2023 00:18
@ikawaha ikawaha marked this pull request as draft October 15, 2023 01:08
@ikawaha ikawaha marked this pull request as ready for review October 15, 2023 01:16
@raphael
Copy link
Member

raphael commented Oct 17, 2023

This is great, thank you. One thing I just realized: Goa's release process depends on the top level Makefile of the examples repository, see: https://github.com/goadesign/goa/blob/v3/Makefile#L106. Maybe we should bring the top level Makefile back (and keep the individual Makefiles for each example).

@ikawaha
Copy link
Contributor Author

ikawaha commented Oct 17, 2023

Thank you for pointing that out. I've made the necessary adjustments and created a PR to address this concern #138. I've ensured that the top-level Makefile is restored while retaining the individual Makefiles for each example.

By executing the command make GOA_VERSION=v3.13.2, the modules within examples will be regenerated using the specified version of goa, in this case, version v3.13.2. This allows for easy updating and testing of modules in accordance with a specific goa version.

@raphael
Copy link
Member

raphael commented Oct 18, 2023

Great, thank you!

@raphael raphael merged commit 5991b4e into goadesign:master Oct 18, 2023
1 check passed
@ikawaha ikawaha deleted the refact/modularization_tracing branch October 18, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants