-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing sql.Scanner/driver.Value interfaces to uuid.UUID #610
Conversation
Thank you! I think we need to revisit how we approach the problem. Including all that code doesn't feel very satisfactory :). The basic problem @skritchz is trying to fix is to remove the use of |
Yea, the Goa uuid.UUID was introduced to remove the usage of the satori package. Any tips on how to use the satori package and still make goperJS happy? |
What I'm suggesting above is to use the satori package server side ( |
@@ -269,7 +269,7 @@ func (g *Generator) generateClientResources(pkgDir, clientPkg string, funcs temp | |||
codegen.SimpleImport("io"), | |||
codegen.SimpleImport("net/http"), | |||
codegen.SimpleImport("time"), | |||
codegen.NewImport("uuid", "github.com/goadesign/goa/uuid"), | |||
codegen.NewImport("uuid", "github.com/satori/go.uuid"), |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Reverted change of using satori/go.uuid in Client code. |
17be595
to
b78f3e9
Compare
var t interface{} | ||
err := json.Unmarshal([]byte(val), t) | ||
if err != nil { | ||
panic(err) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Use complex types when calling the client
Client is generated fully typed with bool and float64
…files are not important here
Awesome PR, thank you! |
You're welcome! :) |
Copy implementation from satori/go.uuid/uuid.UUID
fixes #609
A bit crude fix, but works.. Better suggestion?