Internal: Fix PHPUnit deprecated prophecy integration

[tbsiqueira]

Problem

PHPUnit deprecated prophecy integration on sebastianbergmann/phpunit#4141

Solution

There a couple of approaches, all suggested on the above PR:

• Use prophecy directly, suggested here Deprecate Prophecy integration sebastianbergmann/phpunit#4141 (comment)

• Use a rector suggested here Deprecate Prophecy integration sebastianbergmann/phpunit#4141 (comment)

Whatever the method, unit tests should still work.

Issue tracker

N/A

Theme issue tracker

N/A

How to test

• Make sure unit tests are still working.

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• New features or changes to existing features are covered by tests, either unit (preferably) or behat
• Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

N/A

Change Record

N/A

Translations

N/A

[mergeable]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

[Kingdutch]

Is it a good idea to do this in tear down rather than on a per-test basis? I'm not sure how reporting will differ ("There was an error in cleaning up" vs "Your test failed").

I.e. the underlying question is: Does PHPUnit already consider the test case a success if it performs tearDown? If the answer is yes, we should move this.

[tbsiqueira]

Hi Alexander,

Is it a good idea to do this in tear down rather than on a per-test basis? I'm not sure how reporting will differ ("There was an error in cleaning up" vs "Your test failed").

According to https://phpunit.readthedocs.io/en/9.5/fixtures.html#fixtures setUp() and tearDown() template methods are run once for each test method (and on fresh instances) of the test case class. and Example Example 4.2 has a nice explanation on how they work.

I.e. the underlying question is: Does PHPUnit already consider the test case a success if it performs tearDown? If the answer is yes, we should move this.

According to official documentation from prophecy tearDown() is where we should call checkPredictions()
Please check here for more information: https://github.com/phpspec/prophecy#predictions

[Kingdutch]

If official documentation says it, then that's good enough for me 👍

[tbsiqueira]

Cherry-picked to 11.5.x here 5c464c4