Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node grants for "group" visibility #4110

Open
wants to merge 1 commit into
base: feature/3458767-replace-node-grants
Choose a base branch
from

Conversation

nechai
Copy link
Contributor

@nechai nechai commented Oct 9, 2024

Caution

PR should be merged in #3961

Note

This PR doesn't require behat tests passing. Tests should be checked in #3961

Replace node grants with query alters for nodes with group visibilities.
More details about the reasons why we need this PR can be found at #4098

Copy link

github-actions bot commented Oct 9, 2024

Thanks for opening this Pull Request! To ensure Pull Requests are easy to find and understand for all our team-members we've established some standardised rules. While reviewing this pull request I've found the following issues, please resolve them.

Multiple type labels selected
The pull request has multiple type labels selected which may indicate you're trying to do too much at once. Consider splitting up the pull request and select the single most appropriate type.

Missing milestone
The issue is missing a milestone. Milestones are important to help release managers know whether they might need to postpone a release for a critical issue and to communicate what fixes and new features are included in a release. Before merging, please select the appropriate milestone for this pull request.

Invalid Title
The title you've provided for this pull request does not follow the expected title formats. Consistent titles make origins and purposes of issues easy to understand. Please use one of the following title formats:

  • PROD-NNN: for a PR related to an Open Social Jira issue
  • Issue #NNN: for a PR originating from a Drupal.org issue.
  • Internal: for a repository maintenance PR without matching Jira ticket (prefer creating a ticket to track your work).
  • Updates: for a PR that updates modules (e.g. by dependabot).
  • Hotfix: in case it's really important something gets fixed now.

Choose the proper prefix and write a title that tells developers without other context what your PR is about. Do NOT end your title with a period.

🤖 This is an automatically produced message by the Open Social PR manager.

@nechai nechai force-pushed the feature/replace-node-grants-gnode branch 3 times, most recently from 0e2fd0c to e2c4496 Compare October 11, 2024 15:52
@nechai nechai added type: refactoring Updates code for improved maintenance without changing its functionality team: enterprise This PR originates from the ECI team type: feature Adds a new feature to Open Social prio: medium labels Oct 15, 2024
@nechai nechai force-pushed the feature/replace-node-grants-gnode branch from e2c4496 to 40e3178 Compare October 15, 2024 13:29
@nechai nechai force-pushed the feature/3458767-replace-node-grants branch from 3b2a0de to b52e1bb Compare November 7, 2024 11:14
@nechai nechai force-pushed the feature/replace-node-grants-gnode branch from 40e3178 to 1735f0a Compare November 7, 2024 11:31
@nechai nechai force-pushed the feature/replace-node-grants-gnode branch from 1735f0a to ca62820 Compare November 7, 2024 11:32
@open-social-tugboat
Copy link

Tugboat has finished building the preview for this pull request!

Link:

Dashboard:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium team: enterprise This PR originates from the ECI team type: feature Adds a new feature to Open Social type: refactoring Updates code for improved maintenance without changing its functionality
Development

Successfully merging this pull request may close these issues.

2 participants