Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-31064: Replace node grants in Search API #4116

Open
wants to merge 7 commits into
base: feature/3458767-replace-node-grants
Choose a base branch
from

Conversation

nechai
Copy link
Contributor

@nechai nechai commented Oct 15, 2024

Caution

PR should be merged in #3961

Note

This PR doesn't require behat tests passing. Tests should be checked in #3961

Replace node grants for search API queries.
More details about the reasons why we need this PR can be found at #4098

@nechai nechai self-assigned this Oct 15, 2024
@nechai nechai force-pushed the feature/replace-node-grants-search-api branch 2 times, most recently from 83935f7 to 4565a09 Compare November 4, 2024 10:43
@nechai nechai changed the title Replace node grants in Search API Introduce the Social entity query access alter system Nov 4, 2024
@nechai nechai changed the title Introduce the Social entity query access alter system Replace node grants for Search API Nov 4, 2024
@nechai nechai changed the title Replace node grants for Search API Replace node grants in Search API Nov 4, 2024
@nechai nechai force-pushed the feature/replace-node-grants-search-api branch 2 times, most recently from 908e520 to 26abf3b Compare November 7, 2024 11:10
@nechai nechai force-pushed the feature/3458767-replace-node-grants branch from 3b2a0de to b52e1bb Compare November 7, 2024 11:14
@nechai nechai marked this pull request as ready for review November 7, 2024 11:36
@nechai nechai force-pushed the feature/replace-node-grants-search-api branch 2 times, most recently from f22fe99 to 56ac1f2 Compare November 7, 2024 11:40
@nechai nechai requested a review from Kingdutch November 7, 2024 11:40
@nechai nechai force-pushed the feature/replace-node-grants-search-api branch from 56ac1f2 to cda5ecd Compare November 8, 2024 13:53
Copy link
Contributor

@tregismoreira tregismoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


$index->removeProcessor('content_access');
\Drupal::messenger()
->addWarning(t('"Content Access" processor is not allowed for using (replaced by query alters).'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
->addWarning(t('"Content Access" processor is not allowed for using (replaced by query alters).'));
->addWarning(t('"Content Access" processor is deprecated, and it's replaced by query alters.'));

* "preprocess_query" = -30,
* },
* locked = true,
* hidden = true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nechai as we discussed would be good to make at least this one visible from UI.

*
* @SearchApiProcessor(
* id = "social_search_tagging_query",
* label = @Translation("Tagging queries"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to rename it to something more specific, like Social entity access

@nechai nechai force-pushed the feature/3458767-replace-node-grants branch from ec9b509 to a882e33 Compare December 20, 2024 10:18
@ribel ribel changed the title Replace node grants in Search API PROD-31064: Replace node grants in Search API Dec 20, 2024
@nechai nechai force-pushed the feature/replace-node-grants-search-api branch from 8024456 to 42b2c02 Compare December 20, 2024 10:32
@ribel ribel added this to the 13.0.0-alpha22 milestone Dec 20, 2024
@ribel ribel added team: enterprise This PR originates from the ECI team prio: high status: needs work This pull request needs more work before it's ready for review type: refactoring Updates code for improved maintenance without changing its functionality needs work: rebase This pull request is too far behind its target branch and requires a rebase type: performance Improve Open Social performance and removed type: refactoring Updates code for improved maintenance without changing its functionality labels Dec 20, 2024
These conditions groups allows developers to subscribe to each group (because it is tagged) and add own conditions or alters
@nechai nechai force-pushed the feature/replace-node-grants-search-api branch from 42b2c02 to 8b7e3c4 Compare December 20, 2024 12:57
@open-social-tugboat
Copy link

Tugboat has finished building the preview for this pull request!

Link:

Dashboard:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work: rebase This pull request is too far behind its target branch and requires a rebase prio: high status: needs work This pull request needs more work before it's ready for review team: enterprise This PR originates from the ECI team type: performance Improve Open Social performance
Development

Successfully merging this pull request may close these issues.

4 participants