-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-31064: Replace node grants in Search API #4116
base: feature/3458767-replace-node-grants
Are you sure you want to change the base?
PROD-31064: Replace node grants in Search API #4116
Conversation
83935f7
to
4565a09
Compare
908e520
to
26abf3b
Compare
3b2a0de
to
b52e1bb
Compare
f22fe99
to
56ac1f2
Compare
56ac1f2
to
cda5ecd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
$index->removeProcessor('content_access'); | ||
\Drupal::messenger() | ||
->addWarning(t('"Content Access" processor is not allowed for using (replaced by query alters).')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
->addWarning(t('"Content Access" processor is not allowed for using (replaced by query alters).')); | |
->addWarning(t('"Content Access" processor is deprecated, and it's replaced by query alters.')); |
* "preprocess_query" = -30, | ||
* }, | ||
* locked = true, | ||
* hidden = true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nechai as we discussed would be good to make at least this one visible from UI.
* | ||
* @SearchApiProcessor( | ||
* id = "social_search_tagging_query", | ||
* label = @Translation("Tagging queries"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to rename it to something more specific, like Social entity access
ec9b509
to
a882e33
Compare
8024456
to
42b2c02
Compare
These conditions groups allows developers to subscribe to each group (because it is tagged) and add own conditions or alters
…unity" visibilities
42b2c02
to
8b7e3c4
Compare
Tugboat has finished building the preview for this pull request! Link: Dashboard: |
Caution
PR should be merged in #3961
Note
This PR doesn't require behat tests passing. Tests should be checked in #3961
Replace
node grants
for search API queries.More details about the reasons why we need this PR can be found at #4098