Issue #3490982: Usernames in activity streams shouldn't be translatable

[navneet0693]

Problem (for internal)

The usernames of the people in the streams were getting translated when using an external translation tool like Google Translation. They shouldn't be translatable

The output in the stream is coming from message templates text ( https://github.com/goalgorilla/open_social/blob/main/modules/custom/activity_creator/src/ActivityFactory.php#L146 ) which is getting added on activity page in https://github.com/goalgorilla/open_social/blob/main/modules/custom/activity_creator/activity.page.inc#L38 which then gets added in https://git.drupalcode.org/project/socialbase/-/blob/2.6.x/templates/activity/activity.html.twig?ref_type=heads#L48

Solution (for internal)

We added “no translate” attribute with message output text.

Release notes (to customers)

We smashed a bug where our usernames in the activity streams were getting translated when using third party services like Google Translate

Issue tracker

https://www.drupal.org/project/social/issues/3490982

Theme issue tracker

N.A

How to test

• Install a multilingual Open Social website
• Create content in different language (other than English)
• Use module that provides third party translators to convert them in different languages
• This is tricky that which username or word it picks for translation, but observe the usernames in activity stream
• Checkout to this branch
• Run updates
• Try translating again
• You should observe that usernames will remain same.

Change Record

N.A

Translations

N.A

[open-social-tugboat]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr4226-azrxucvdddkg0fh3dvivko60rxuohaaw.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/674e8502b8d4abaca9a4dbbf