PROD-31305: Non verified users are not able to see their profile properly #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcsvinicius
added
type: bug
vcsvinicius
force-pushed
the
bugfix/PROD-31305/fix-access-to-own-profile-non-verified-user
branch
2 times, most recently
from
2edea62 to
badf9d0
Compare
Kingdutch
requested changes
Dec 10, 2024
modules/social_features/social_profile/src/Plugin/views/access/SocialProfilePagesAccess.php
Outdated
Show resolved
Hide resolved
Comment on lines
71
to
90
| // Load the user entity. | ||
| $user_id = $this->routeMatch->getRawParameter('user'); | ||
| $user = $this->entityTypeManager->getStorage('user') | ||
| ->load($user_id); | ||
| if (!$user instanceof UserInterface) { | ||
| return AccessResult::forbidden(); | ||
| } | ||
|
|
||
| // If user is blocked, check special permission. | ||
| if ($user->isBlocked()) { | ||
| return AccessResult::allowedIfHasPermissions($account, ['view blocked user']); | ||
| } | ||
|
|
||
| // Check if current page is from logged user. | ||
| if ($account->id() === $user->id()) { | ||
| return AccessResult::allowedIfHasPermissions($account, ['view own profile profile']); | ||
| } | ||
|
|
||
| // Check if logged user can view all profiles. | ||
| return AccessResult::allowedIfHasPermissions($account, ['view any profile profile']); |
There was a problem hiding this comment.
How does this logic differ from what would be evaluated if we called $profile->access('view', $account);?
What happens if other modules change when a user can be viewed by using Drupal's access APIs?
There was a problem hiding this comment.
I debugged with entity-access instead of custom-access and I found where and why the isn't give access.
The validation happen here: html/core/lib/Drupal/Core/Entity/EntityAccessCheck.php:65
The code try to found a parameter with profile, but the view has user as parameter, so to work we need to add this on view.
vcsvinicius
force-pushed
the
bugfix/PROD-31305/fix-access-to-own-profile-non-verified-user
branch
from
badf9d0 to
6c5b246
Compare
vcsvinicius
force-pushed
the
bugfix/PROD-31305/fix-access-to-own-profile-non-verified-user
branch
from
6c5b246 to
c578657
Compare
vcsvinicius
force-pushed
the
bugfix/PROD-31305/fix-access-to-own-profile-non-verified-user
branch
from
c578657 to
90ef4d0
Compare
|
Non-verified user is able to access their information: |
|
Tugboat has finished building the preview for this pull request! Link: Dashboard: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem (for internal)
Non verified user can't access they own profile information page.
Solution (for internal)
I created a custom Access View for check the access for User Information page.
Release notes (to customers)
Fixed the access for non-verified user on Profile User Information page.
Issue tracker
PROD-31305
Theme issue tracker
N/A
How to test
Change Record
N/A
Translations
N/A