Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3495014: Fix display of the field and the label of the enrolment limit in the event #4262

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

Agamich-FE
Copy link
Collaborator

@Agamich-FE Agamich-FE commented Dec 19, 2024

Problem (for internal)

The enrollment limit label should not be visible when the limit is disabled.

Solution (for internal)

Add condition and check if the Enable maximum number of event enrollments setting is disabled and hide the Enrollment limit option on the event create form.

Before:
Screenshot 2024-12-05 at 11 56 08

Screenshot 2024-12-05 at 11 56 01

After:
Screenshot 2024-12-19 at 14 54 39

Release notes (to customers)

When the Event enrollment limit is disabled the user does not see the field or the label of the enrollment limit in the event

Issue tracker

Theme issue tracker

How to test

  • Enable the social_event_max_enroll module.
  • Go to the /admin/config/opensocial/event-max-enroll page and check if the Enable maximum number of event enrollments checkbox is enabled.
  • Go to the /node/add/event page.
  • Scroll to the Access permissions section and find the Enrollment limit.
  • Go to the /admin/config/opensocial/event-max-enroll page and uncheck the Enable maximum number of event enrollments checkbox.
  • Go to the /node/add/event page.
  • Scroll to the Access permissions section and check if the Enrollment limit is displayed.

Change Record

Translations

@Agamich-FE Agamich-FE added type: bug Fixes a bug in Open Social team: enterprise This PR originates from the ECI team status: needs review This pull request is waiting for a requested review prio: low labels Dec 19, 2024
@Agamich-FE Agamich-FE added this to the 13.0.0-alpha22 milestone Dec 19, 2024
@Agamich-FE Agamich-FE requested a review from ribel December 19, 2024 12:58
@Agamich-FE Agamich-FE self-assigned this Dec 19, 2024
@Orest-Solinskyi
Copy link

Tested! Works as expected! Thanks

@Agamich-FE Agamich-FE force-pushed the bugfix/3495014-enrollment-limit-event-issue branch from 9f19292 to 7189c0e Compare December 20, 2024 09:19
@ribel ribel changed the title Issue #3495014: Fix display of the field and the label of the enrollm… Issue #3495014: Fix display of the field and the label of the enrolment limit in the event Dec 20, 2024
@ribel ribel merged commit d23bda4 into main Dec 20, 2024
197 checks passed
@ribel ribel deleted the bugfix/3495014-enrollment-limit-event-issue branch December 20, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: low status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

3 participants