Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "ReflectionEngine::setMaximumCachedFiles" doesn't reevaluate existing cache #35

Closed
aik099 opened this issue Jun 17, 2016 · 1 comment

Comments

@aik099
Copy link

aik099 commented Jun 17, 2016

When ReflectionEngine::setMaximumCachedFiles method is called it currently only changes maximal allowed file count in cache. That's perfectly fine, when used prior to file parsing process is started.

Unfortunately, when used in the middle of process (e.g. when got high memory consumption I try to reduce cached file count), then nothing happens.

I expect existing cache to be sliced (from oldest to newest) to reduce cache to given size (or smaller if less files are cached, then requested).

@lisachenko
Copy link
Member

This can be implemented in the setter, why not...

lisachenko added a commit that referenced this issue Jun 23, 2016
Resize the cache size after changing the maximum limti, resolves #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants