-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Lumina 5 (new Excel parsing) #2022
Conversation
Until Lumina is updated to v5 and ExdSheets is upstreamed to Lumina.Excel, you'll need to resolve the dll paths by compiling WorkingRobot/ExdGenerator on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the CS bump. If you need it, let us know so that we can upstream the proper changes. Completed, thank you.
As noted as well, this'll be blocked until Lumina updates itself and/or we decide that we want to maintain our own repo/project separately.
49e4ed4
to
bfca7d8
Compare
Also, still somewhere on the todo list:
|
bfca7d8
to
aa81928
Compare
Changed this PR to use Lumina.Excel instead. (Use the lumina2 branch) I'm considering writing some sort of generator to allow users to easily create IExcel(Sub)Row types, which will be made available on NuGet. Some features may include inheritance support and automatic generic RowRef generation (it has an additional hash that should be computed at compile time for a 2x speed increase). If there are any suggestions for this future generator, let me know, and I'll work on including them. |
3fc38c6
to
a4ede10
Compare
New Features:
LayoutWorld.AddRsvString
.ExcelResolver
.Lumina.Excel.RowRef
works as a better and more featured alternative now that lazy construction is obsolete/useless.IDataManager
service now accepts astring? name
optional parameter for explicit sheet names.IDataManager.GetSheet
is now split intoIDataManager.GetSubrowSheet
as well.IDataManager.Get(Subrow)Sheet
functions now throw. Not sure if this is 100% a good idea, but I don't like quiet failures for stuff that should be constant and never fail (except for updates and sheet changes). If needed,Lumina.GameData.Get(Subrow)Sheet
is an alternative toLumina.Excel.ExcelModule.Get(Subrow)Sheet
that throws only when the schema/struct type is invalid.