Don't allow nameplate GameObject lookup when ObjectId is invalid #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebel
force-pushed
the
fix-doman-cutscene-nameplates
branch
from
e40e485 to
7ca026d
Compare
goaaats
approved these changes
Dec 4, 2024
KazWolfe
added a commit
that referenced
this pull request
Dec 17, 2024
* Use MiniGame BGM scene for About tab * Use span comparison in GameGui.IsInLobby * [master] Update ClientStructs (#2126) Co-authored-by: github-actions[bot] <noreply@github.com> * [master] Update ClientStructs (#2134) Co-authored-by: github-actions[bot] <noreply@github.com> * [master] Update ClientStructs (#2135) Co-authored-by: github-actions[bot] <noreply@github.com> * Fix config option summaries (#2138) * Fix config option summaries * Obsolete LockonDefaultZoom_179 with error * Don't allow nameplate GameObject lookup when ObjectId is invalid (#2137) * build: 11.0.2.0 * Update ClientStructs (#2139) Co-authored-by: github-actions[bot] <noreply@github.com> * chore: remove [Experimental] from SeStringRenderer (#2144) It hasn't caused problem for a while (though performance probably can be better), and looks good enough to remove this attribute. * Update ClientStructs (#2140) Co-authored-by: github-actions[bot] <noreply@github.com> * Return nullable on XivChatType.GetDetails (#2143) --------- Co-authored-by: Haselnussbomber <mail@haselnussbomber.de> Co-authored-by: github-actions[bot] <noreply@github.com> Co-authored-by: nebel <9887+nebel@users.noreply.github.com> Co-authored-by: goat <goatsdev@protonmail.com> Co-authored-by: goat <16760685+goaaats@users.noreply.github.com> Co-authored-by: srkizer <soreepeong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
GameObjectlookup whenNamePlateInfo->ObjectIdis0xE0000000. Technically these objects can still be looked up despite the invalidObjectId, but doing so and modifying plates as a result seems to result in crashes deep in font rendering code. As this is an unusual case which (to my knowledge) is not seen elsewhere, and the bad ID indicates something is invalid, it's probably correct to skip these lookups.This should fix a crash in the FC Name Color plugin when viewing certain Doman Restoration cutscenes.