Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] WhoAmIAgain v1.0.0.0 #2632

Merged
merged 4 commits into from
Oct 25, 2023
Merged

[Testing] WhoAmIAgain v1.0.0.0 #2632

merged 4 commits into from
Oct 25, 2023

Conversation

MidoriKami
Copy link
Contributor

New plugin for helping you remember who you are.

@bleatbot bleatbot enabled auto-merge (squash) October 7, 2023 21:03
auto-merge was automatically disabled October 7, 2023 21:04

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Oct 7, 2023 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 4 hours.

😰WhoAmIAgain [testing-live] - 9dc2176 - Build system error: No lockfiles present - please set "RestorePackagesWithLockFile" to true in your project file!

Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. labels Oct 7, 2023
@bleatbot
Copy link
Collaborator

bleatbot commented Oct 7, 2023 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

😰WhoAmIAgain [testing-live] - 334a0e8 - Build system error: No lockfiles present - please set "RestorePackagesWithLockFile" to true in your project file!

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Oct 7, 2023 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️WhoAmIAgain [testing-live] - d4fb83a - v1.0.0.0 - Diff (164 lines)

Show log - Review

@bleatbot bleatbot added size-small Diff for this PR is small. and removed build failed This plugin failed to build. labels Oct 7, 2023
@MidoriKami
Copy link
Contributor Author

MidoriKami commented Oct 7, 2023 •
edited
Loading

Link to full code directly: https://github.com/MidoriKami/WhoAmIAgain/blob/master/WhoAmIAgain/WhoAmIAgain.cs
Yes. It is one file. 26 lines of code.

@MidoriKami
Copy link
Contributor Author

MidoriKami commented Oct 8, 2023 •
edited
Loading

image
Yeah, that's all it does.

@reiichi001 reiichi001 added the completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. label Oct 8, 2023
@reiichi001
Copy link
Contributor

This plugin is now in the plugin review queue; we hope to get back to you soon!

@MidoriKami
Copy link
Contributor Author

Just added spacing to the name in the DTR entry from "WhoAmIAgain" to "Who Am I Again?" so it shows up better in /xlsettings

@bleatbot
Copy link
Collaborator

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️WhoAmIAgain [testing-live] - 830c0e3 - v1.0.0.0 - Diff (164 lines)

Show log - Review

@slotthhy slotthhy changed the title WhoAmIAgain v1.0.0.0 [Testing] WhoAmIAgain v1.0.0.0 Oct 25, 2023
@slotthhy slotthhy enabled auto-merge (squash) October 25, 2023 17:17
@slotthhy slotthhy merged commit 6e1f444 into goatcorp:main Oct 25, 2023
2 checks passed
@MidoriKami MidoriKami deleted the patch-67 branch October 25, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slotthhy slotthhy slotthhy approved these changes

Assignees
No one assigned
Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. new plugin This is a new plugin. size-small Diff for this PR is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MidoriKami @bleatbot @reiichi001 @slotthhy