[Testing] FakeName 1.2.2

[ArchiDog1998]

Change your and the others' names visually.

[bleatbot]

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

[philpax]

bleatbot, approve

[bleatbot]

Outdated attempt

⚠️ No builds attempted! This probably means that your owners property is misconfigured.

👽FakeName [testing-live] - 408cf48 - Not your plugin

Show log - Review

[bleatbot]

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️FakeName [testing-live] - 408cf48 - v1.2.0.0 - Repo ^{(New plugin)}

Show log - Review

[philpax]

Sorry for the delay! We're taking this plugin through the review process now and will update as it goes along 🙂

EDIT: I did a code review, but other members of the team wanted to take a closer look. Will update once that's done...

[philpax]

Hi, sorry about how long this has all taken - we've been busy with DT prep and haven't had the chance to get through the backlog.

We're happy with this from a rules perspective, but have a few concerns:

• Can you clarify that other players cannot see the changes you've made locally in the plugin description? This may not be obvious to non-technical users.
• Along the same lines, can you clarify that this does not make you stream-safe as other players can still deanonymise you?
• What steps have you taken to ensure that the changed names do not get sent to the server in any form? I trust that it's a purely visual change, but it's hard to know where data may flow from inspection of your code.

[ArchiDog1998]

Hi! This plugin isn't ready for DT expansion. I am waiting for the goatcorp/Dalamud#1915 merging to make it easier to change the name on the NamePlate. Here are the answers.

• All changes that you make using the plugin are for your client only and other people that you play with or meet in-game will still see your real in-game character name.
• Your character's in-game name can still be tracked by other in-game players or by using other third-party resources so DON'T USE IT TO STREAM as there are people who could track and do harm to you.
• Technically, it displays the fake name by replacing the text in SeString. These are two places to modify game data. So the changed data won't be sent to the server. And it is a purely visual change.

[philpax]

Thanks, appreciate it! Looking forward to it 🙂

[reiichi001]

bleatbot, rebuild

[bleatbot]

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌FakeName [testing-live] - 408cf48 - Build failed (Diff)

Show log - Review

[ArchiDog1998]

Hi, this plugin is DawnTrail ready!

[bleatbot]

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️FakeName [testing-live] - 28fe44a - v1.2.2.0 - Repo ^{(New plugin)}

Show log - Review

[philpax]

bleatbot, rebuild

[bleatbot]

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️FakeName [testing-live] - 28fe44a - v1.2.2.0 - Repo ^{(New plugin)}

Show log - Review

[haroldiedema]

This one is consistently silently crashing me to desktop if you give the primary player a name of the maximum amount of characters the input box allows. It does not seem to matter if a first and last name is given. There are no errors in any of the logs, and I'm not getting an exception window.

You can easily reproduce this at the character selection screen and hovering over your different characters. Feels like an Atk/UI issue.

[philpax]

Hi; I'm very sorry about the back-and-forth on this, as well as the time it's taken to reach this conclusion.

We were initially in favour of merging this, but there were concerns raised by members of the community with regards to its potential for abuse. Based on this, and further internal discussion, we have reached the conclusion that we can't accept this plugin as its potential for abuse outweighs its positive use cases.

We apologise for this outcome and the time it took to reach it, and we hope that you're willing to submit other plugins in future.