Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xivcombo 7.1 #5131

Merged
merged 3 commits into from
Dec 6, 2024
Merged

xivcombo 7.1 #5131

merged 3 commits into from
Dec 6, 2024

Conversation

attickdoor
Copy link
Contributor

No description provided.

@bleatbot bleatbot enabled auto-merge (squash) November 29, 2024 17:35
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 29, 2024 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 6 hours.

Name Commit Status
❌ XIVCombo [stable] 53f61f0 Build failed (Diff)
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Nov 29, 2024
@reiichi001
Copy link
Contributor

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 29, 2024 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
❌ XIVCombo [stable] 53f61f0 Build failed (Diff)
1 hidden need (known safe NuGet packages).
Show log - Review

@reiichi001
Copy link
Contributor

XIVComboPlugin/packages.lock.json needs to also be updated. (Rebuild locally, and commit the new one / update hash for TOML)

@reiichi001
Copy link
Contributor

I've PRed MKhayle/XIVComboPlugin#362 to fix this.

auto-merge was automatically disabled December 2, 2024 15:40

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 2, 2024 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
⚠️ XIVCombo [stable] 617962b Same version!!! v1.8.5.0 - Diff (5 lines, prev. 1.8.5.0) - Semantic
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added version conflict This plugin was built with a lower or the same version. size-small Diff for this PR is small. and removed build failed This plugin failed to build. labels Dec 2, 2024
@reiichi001
Copy link
Contributor

I've PRed MKhayle/XIVComboPlugin#364 to fix the new/current build issue.

Given the scope, it may be best to add 1-2 trusted individuals who are active in the community to help with maintenance-only PRs like updating the signature, Dalamud Plugin API updates, and up to date dependencies. Or potentially place the plugin up for adoption and the plugin review/approval team will sort out maintainers for you.

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 6, 2024

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ XIVCombo [stable] 35c8e78 v1.8.6.0 - Diff (6 lines, prev. 1.8.5.0) - Semantic
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot removed the version conflict This plugin was built with a lower or the same version. label Dec 6, 2024
@reiichi001 reiichi001 merged commit 6ac7ffd into goatcorp:main Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reiichi001 reiichi001 reiichi001 approved these changes

Assignees
No one assigned
Labels
size-small Diff for this PR is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@attickdoor @bleatbot @reiichi001