add cmake support for linux/mac/windows #590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a complete reproduction of the autotools code in cmake, with improvements where cmake has an advantage. The options are documented in README.md Dependencies on Windows with Visual Studio are handled with vcpkg, and the `VCPKG_TARGET_TRIPLET` variable can activate vcpkg support on other platforms as well. Include the FindPython2 cmake modules as they are not in the base cmake package on Ubuntu. Make some minor fixes to the autotools code as well, for things broken by adding the cmake support and some other fixes. Signed-off-by: Rafael Kitover <rkitover@gmail.com>
rkitover
changed the title
|
@goatpig this is the work Scott Millar contracted me to do on upwork. I just updated it with my latest changes. Windows support now works as well, seamlessly with dependency handling through vcpkg, at least for ArmoryDB. This version should be mostly complete and does everything the autotools code does. Some of this cmake code needs to be sent upstream to the relevant libraries, with appropriate changes, but that's a separate project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete reproduction of the autotools code in cmake, with
improvements where cmake has an advantage.
The options are documented in README.md
Dependencies on Windows with Visual Studio are handled with vcpkg, and
the
VCPKG_TARGET_TRIPLETvariable can activate vcpkg support on otherplatforms as well.
Include the FindPython2 cmake modules as they are not in the base cmake
package on Ubuntu.
Make some minor fixes to the autotools code as well, for things broken
by adding the cmake support and some other fixes.
Signed-off-by: Rafael Kitover rkitover@gmail.com