Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for stumpless_open_buffer_target #466

Conversation

m3g4d1v3r
Copy link
Contributor

This pull request is related to solving the issue for adding a new benchmark for stumpless_open_buffer_target. A new benchmark file was also added as described on the issue 449.

This is a Work in Progress: I hope to improve this progressively through feedback from the community.

@m3g4d1v3r m3g4d1v3r force-pushed the 449-add-benchmark-for-stumpless-open-buffer-target branch from 60aceda to 9dd6188 Compare October 15, 2024 08:39
@m3g4d1v3r
Copy link
Contributor Author

Issue #449

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (1d2df58) to head (5ef831e).
Report is 2 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest     #466      +/-   ##
==========================================
+ Coverage   90.59%   90.60%   +0.01%     
==========================================
  Files          47       47              
  Lines        4379     4385       +6     
  Branches      587      587              
==========================================
+ Hits         3967     3973       +6     
  Misses        279      279              
  Partials      133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m3g4d1v3r m3g4d1v3r force-pushed the 449-add-benchmark-for-stumpless-open-buffer-target branch from 9dd6188 to 9c291c9 Compare October 15, 2024 09:35
@goatshriek goatshriek self-assigned this Oct 17, 2024
Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great! Just one change requested to bring the resource usage down a bit.

test/performance/target/buffer.cpp Outdated Show resolved Hide resolved
@m3g4d1v3r m3g4d1v3r force-pushed the 449-add-benchmark-for-stumpless-open-buffer-target branch from da75262 to 3cc868e Compare October 23, 2024 14:22
@m3g4d1v3r m3g4d1v3r force-pushed the 449-add-benchmark-for-stumpless-open-buffer-target branch from 3cc868e to 5ef831e Compare October 24, 2024 11:34
@goatshriek goatshriek merged commit 71dc567 into goatshriek:latest Oct 25, 2024
56 checks passed
@goatshriek
Copy link
Owner

Thanks very much for putting this change together and sticking with it through the review process!

@goatshriek goatshriek added the hacktoberfest-accepted accepted work that is valid for hacktoberfest label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted accepted work that is valid for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants