Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated benchmark documentation to match code #467

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from
Open

updated benchmark documentation to match code #467

wants to merge 1 commit into from

Conversation

Brijeshthummar02
Copy link

issue #444

@Brijeshthummar02
Copy link
Author

@goatshriek need review.

@goatshriek goatshriek self-assigned this Oct 17, 2024
goatshriek
goatshriek requested changes Oct 17, 2024
View reviewed changes
Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the actual test in test/performance/element.cpp. The changes you have made here do not make the documentation match it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goatshriek goatshriek goatshriek requested changes

Assignees

@goatshriek goatshriek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brijeshthummar02 @goatshriek