Defer 'Store#emitChange' until promise resolve #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehcode
force-pushed
the
feature-store-promise
branch
from
7c279ff to
51fe5ef
Compare
mehcode
force-pushed
the
feature-store-promise
branch
from
51fe5ef to
2378c07
Compare
|
This is fairly clean. Some initial thoughts: this needs to check if Promise exists, this only works for one store? |
| if (result !== false && this[SET_STATE] === false) { | ||
| this.emitChange() | ||
| if (this[SET_STATE] === false) { | ||
| if (result instanceof Promise) { |
There was a problem hiding this comment.
I've included this change in #234
There was a problem hiding this comment.
Looks awesome; thanks for taking this and making it much better. 👍
There was a problem hiding this comment.
I know this is an old commit that doesn't seem that it'll get merged it. Just an FYI that object instanceof Promise fails on Chrome for native promises.
There was a problem hiding this comment.
👍 we have an isPromise check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.