Component did connect hook #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking it would be a static function similar to how getPropsFromStores is already |
|
If you make it a static, then it will fire every time any of the components are mounted, and you would not have no access to this. Seemed weird to me that it would fire for every mount, but not have access to this. I can switch it if you want though, then it wouldn't require a ref, which is nice. |
| @@ -66,6 +66,9 @@ function connectToStores(Component) { | |||
| stores.forEach((store) => { | |||
| store.listen(this.onChange) | |||
| }) | |||
| if (typeof Component.componentDidConnect === 'function') { | |||
There was a problem hiding this comment.
we can assume its a function
and we should pass in props and context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an API for component did connect, I am not sure if this was where you wanted it in the source, not quite sure how to ensure it makes it into the decorator. Let me know if you want me to change it.