Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: add MeshCentral #10490

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

axemann
Copy link

@axemann axemann commented Jul 13, 2024

Details

This PR adds documentation for integrating authentik with MeshCentral.

No API or frontend changes have been made.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@axemann axemann requested a review from a team as a code owner July 13, 2024 17:08
Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 0ccd07e
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/669d1e16f3b5d80008dbcca1
😎 Deploy Preview https://deploy-preview-10490--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 0ccd07e
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/669d1e16197ff60008684a1d
😎 Deploy Preview https://deploy-preview-10490--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

website/integrations/services/meshcentral/index.md Outdated Show resolved Hide resolved
website/integrations/services/meshcentral/index.md Outdated Show resolved Hide resolved
website/integrations/services/meshcentral/index.md Outdated Show resolved Hide resolved

## MeshCentral configuration

Edit the `config.json` for your MeshCentral deployment, and add the following code in the `domains:` subsection:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add where the config json is located? if needed

@rissson rissson changed the title Add MeshCentral Integration docs website/integrations: add MeshCentral Jul 15, 2024
axemann and others added 3 commits July 16, 2024 13:48
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (fd1d252) to head (0ccd07e).
Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10490      +/-   ##
==========================================
- Coverage   92.61%   92.60%   -0.01%     
==========================================
  Files         714      714              
  Lines       35010    35010              
==========================================
- Hits        32423    32422       -1     
- Misses       2587     2588       +1     
Flag Coverage Δ
e2e 49.58% <ø> (-0.01%) ⬇️
integration 25.36% <ø> (ø)
unit 90.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4d62
Copy link
Contributor

4d62 commented Jul 17, 2024

could you also switch out the > to use docsaurrus' warning / error boxes

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @axemann for this contribution. MeshCentral looks kinda cool! I have a couple of nits and suggestions. Also, I noticed that the build check for prettier failed.. can you run make website or npm run prettier and then push to the PR again? Let me know if you have any questions; here are our docs for how to run the required linting before pushing a PR. https://docs.goauthentik.io/developer-docs/docs/writing-documentation

website/integrations/services/meshcentral/index.md Outdated Show resolved Hide resolved
website/integrations/services/meshcentral/index.md Outdated Show resolved Hide resolved
website/integrations/services/meshcentral/index.md Outdated Show resolved Hide resolved
axemann and others added 6 commits July 21, 2024 09:39
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
@axemann axemann requested a review from tanberry July 21, 2024 14:18
@tanberry
Copy link
Contributor

Hi @axemann it seems the prettier-check is still failing... were you able to run the formatting command make website before pushing the latest commits? If you are doing this work in a local repo, that's this easiest way. Or are you doing this via the GitHub UI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants