sources/ldap: Add enabled filter for ldap_password_validate signal #10823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs canceled.
|
BeryJu
changed the title
BeryJu
approved these changes
Aug 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10823 +/- ##
==========================================
+ Coverage 92.62% 92.64% +0.01%
==========================================
Files 734 735 +1
Lines 36039 36096 +57
==========================================
+ Hits 33380 33440 +60
+ Misses 2659 2656 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/cherry-pick version-2024.6 |
kensternberg-authentik
added a commit
that referenced
this pull request
Aug 8, 2024
* main: (25 commits) website/docs: add link from Install docs to Enterprise docs (#10827) website/docs: new upgrade page (#10742) stages/authenticator: actually update last_used (#10813) sources/ldap: Add enabled filter for ldap_password_validate signal (#10823) web: bump API Client version (#10821) sources/plex: add property mappings (#10772) core: bump goauthentik.io/api/v3 from 3.2024063.2 to 3.2024063.5 (#10817) web: bump the wdio group across 2 directories with 4 updates (#10818) web: bump chromedriver from 127.0.1 to 127.0.2 in /tests/wdio (#10819) web: update to ESLint 9 (#10812) website/docs: add source property mappings, rework provider property mappings (#10652) web/admin: refactor property mappings forms (#10810) web: bump API Client version (#10811) sources/saml: Basic support for EncryptedAssertion element. (#10099) web: bump API Client version (#10809) sources: add property mappings for all oauth and saml sources (#8771) web: bump API Client version (#10808) stages/authenticator: add created, last_updated and last_used metadata (#10636) providers/proxy: avoid erroring on logout with session_id is None (#9119) core: bump google-api-python-client from 2.139.0 to 2.140.0 (#10802) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Disabled LDAP Sources are still queried causing issues when trying to change or validate passwords via Stages. The issues is a result of the line:
sources = LDAPSource.objects.filter(sync_users_password=True)The filter only checks if the sync_users_password checkbox is true, but should additionally check if the Source is enabled.
closes #10822
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)