Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/scim: optimize sending all members within a group (2024.6.3) #10931

Closed

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 15, 2024

Details

#9968 but on 2024.6.3


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner August 15, 2024 15:52
@BeryJu BeryJu changed the title providers/scim: optimize sending all members within a group providers/scim: optimize sending all members within a group (2024.6.3) Aug 15, 2024
Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 37fe50d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66bf275ed9054e000803f679

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.62%. Comparing base (b727656) to head (37fe50d).

Files Patch % Lines
authentik/providers/scim/clients/groups.py 82.60% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           version-2024.6   #10931   +/-   ##
===============================================
  Coverage           92.61%   92.62%           
===============================================
  Files                 714      714           
  Lines               35029    35046   +17     
===============================================
+ Hits                32443    32460   +17     
  Misses               2586     2586           
Flag Coverage Δ
e2e 49.67% <20.68%> (+0.06%) ⬆️
integration 25.33% <0.00%> (-0.02%) ⬇️
unit 90.10% <86.20%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/scim/optimize-member-full-send-2024-6-3 branch from 3e0be7a to 6d3c419 Compare August 15, 2024 16:29
Copy link
Contributor

github-actions bot commented Aug 15, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-37fe50d97af9e50ec2309cfbff5253282dbdb4b9
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-37fe50d97af9e50ec2309cfbff5253282dbdb4b9-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-37fe50d97af9e50ec2309cfbff5253282dbdb4b9

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-37fe50d97af9e50ec2309cfbff5253282dbdb4b9-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly easy to grok what's going on here.

@BeryJu BeryJu closed this Aug 22, 2024
@BeryJu BeryJu deleted the providers/scim/optimize-member-full-send-2024-6-3 branch August 22, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants