website/integrations: Fix Nextcloud SAML Docs for SLO #11118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The given SLO URL for authenticating in Nextcloud with SAML is missing a required trailing slash. If it's not there, it will not be possible to log out in a Nextcloud instance that has been set up according to the docs. Signed-off-by: Jonathan Lai <laiks.jonathan@gmail.com>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BeryJu
changed the title
kensternberg-authentik
added a commit
that referenced
this pull request
Aug 29, 2024
* main: websites/docs: minor tweaks to rel notes (#11123) website/docs: fix outdated docs and typos (#11020) web: fix e2e tests to work with latest WebdriverIO and authentik 2024.8 (#11105) website/integrations: Fix Nextcloud SAML Docs for SLO (#11118) core: bump twisted from 24.3.0 to 24.7.0 (#11119) ci: fix failing release attestation (#11107) core: bump importlib-metadata from 8.0.0 to 8.4.0 (#11112) core: bump google-api-python-client from 2.142.0 to 2.143.0 (#11113) core: bump selenium from 4.23.1 to 4.24.0 (#11114) web: bump the swc group across 2 directories with 11 updates (#11115) enterprise: fix incorrect comparison for latest validity date (#11109) website/docs: 2024.8 release notes: reword group sync disable and fix… (#11103) website/docs: add info about external users (#11106) website/docs: a couple of minor rewrite things (#11099) web: bump @sentry/browser from 8.26.0 to 8.27.0 in /web in the sentry group across 1 directory (#11093) website: bump webpack from 5.89.0 to 5.94.0 in /website (#11098) website/docs: fix nginx ingress auth-signin example (#11096) core: bump github.com/jellydator/ttlcache/v3 from 3.2.1 to 3.3.0 (#11091) core: bump pdoc from 14.6.0 to 14.6.1 (#11092) web: bump @patternfly/elements from 4.0.0 to 4.0.1 in /web (#11094)
kensternberg-authentik
added a commit
that referenced
this pull request
Aug 30, 2024
* main: website/docs: fix outdated docs and typos (#11020) web: fix e2e tests to work with latest WebdriverIO and authentik 2024.8 (#11105) website/integrations: Fix Nextcloud SAML Docs for SLO (#11118) core: bump twisted from 24.3.0 to 24.7.0 (#11119) ci: fix failing release attestation (#11107) core: bump importlib-metadata from 8.0.0 to 8.4.0 (#11112) core: bump google-api-python-client from 2.142.0 to 2.143.0 (#11113) core: bump selenium from 4.23.1 to 4.24.0 (#11114) web: bump the swc group across 2 directories with 11 updates (#11115) enterprise: fix incorrect comparison for latest validity date (#11109) website/docs: 2024.8 release notes: reword group sync disable and fix… (#11103) website/docs: add info about external users (#11106) website/docs: a couple of minor rewrite things (#11099) web: bump @sentry/browser from 8.26.0 to 8.27.0 in /web in the sentry group across 1 directory (#11093) website: bump webpack from 5.89.0 to 5.94.0 in /website (#11098) website/docs: fix nginx ingress auth-signin example (#11096) core: bump github.com/jellydator/ttlcache/v3 from 3.2.1 to 3.3.0 (#11091) core: bump pdoc from 14.6.0 to 14.6.1 (#11092) web: bump @patternfly/elements from 4.0.0 to 4.0.1 in /web (#11094)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The given SLO URL for authenticating in Nextcloud with SAML is missing a required trailing slash.
If it's not there, it will not be possible to log out in a Nextcloud instance that has been set up according to the docs.
This PR just adds that trailing slash to the Nextcloud documentation page.