Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/ldap: fix missing search attribute #11125

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 29, 2024

Details

closes #11122

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners August 29, 2024 19:30
@BeryJu
Copy link
Member Author

BeryJu commented Aug 29, 2024

/cherry-pick version-2024.8

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 3f2b156
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66e17871ba02b40008dfb110

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 3f2b156
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66e17871fd75640008bb1df1
😎 Deploy Preview https://deploy-preview-11125--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.66%. Comparing base (dbff42a) to head (3f2b156).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/enterprise/signals.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11125      +/-   ##
==========================================
- Coverage   92.75%   92.66%   -0.09%     
==========================================
  Files         736      736              
  Lines       36487    36490       +3     
==========================================
- Hits        33842    33814      -28     
- Misses       2645     2676      +31     
Flag Coverage Δ
e2e 49.14% <83.33%> (-0.12%) ⬇️
integration 24.97% <50.00%> (+<0.01%) ⬆️
unit 90.20% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the sources/ldap/fix-missing-search-attribute branch from 93d7bba to 3f2b156 Compare September 11, 2024 11:01
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-3f2b15633b6bfdf12c23fbbb4c71f5a1d1391515
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-3f2b15633b6bfdf12c23fbbb4c71f5a1d1391515-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-3f2b15633b6bfdf12c23fbbb4c71f5a1d1391515

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-3f2b15633b6bfdf12c23fbbb4c71f5a1d1391515-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 408fa92 into main Sep 11, 2024
67 of 69 checks passed
@BeryJu BeryJu deleted the sources/ldap/fix-missing-search-attribute branch September 11, 2024 11:34
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 11, 2024
* unrelated

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* sources/ldap: fix ldap sync not requesting uniqueness attribute

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* check object_uniqueness_field for none

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Sep 11, 2024
sources/ldap: fix missing search attribute (#11125)

* unrelated



* sources/ldap: fix ldap sync not requesting uniqueness attribute



* check object_uniqueness_field for none



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object uniqueness field should be explicitly listed as attribute when querying LDAP
1 participant