web/admin: fix misc dual select on different forms #11203

BeryJu · 2024-09-04T11:02:56Z

Details

closes #11197

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu · 2024-09-04T11:03:04Z

/cherry-pick version-2024.8

netlify · 2024-09-04T11:03:12Z

✅ Deploy Preview for authentik-storybook ready!

Name	Link
🔨 Latest commit	`f26d075`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/66d83e63a933930008906ce9
😎 Deploy Preview	https://deploy-preview-11203--authentik-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-09-04T11:03:40Z

✅ Deploy Preview for authentik-docs canceled.

Name	Link
🔨 Latest commit	`f26d075`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/66d83e63764b1300088fcd2e

codecov · 2024-09-04T11:10:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (31ad841) to head (f26d075).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11203      +/-   ##
==========================================
- Coverage   92.75%   92.74%   -0.01%     
==========================================
  Files         736      736              
  Lines       36435    36435              
==========================================
- Hits        33794    33792       -2     
- Misses       2641     2643       +2

Flag	Coverage Δ
e2e	`49.25% <ø> (-0.08%)`	⬇️
integration	`25.00% <ø> (ø)`
unit	`90.21% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-04T11:40:50Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f26d075281922cbc4d9a98f46e71fea980468204
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f26d075281922cbc4d9a98f46e71fea980468204-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-f26d075281922cbc4d9a98f46e71fea980468204

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-f26d075281922cbc4d9a98f46e71fea980468204-arm64

Afterwards, run the upgrade commands from the latest release notes.

gcp-cherry-pick-bot · 2024-09-04T11:45:46Z

Cherry-pick failed with Merge error 30fcdbf05fcd11c7b57f370a8967ecb01c125e15 into temp-cherry-pick-faed1c-version-2024.8

* fix prompt stage Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix identification stage Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix OAuth JWKS sources Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix oauth provider default scopes Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix outpost form Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix webauthn Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix transport form Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> # Conflicts: # web/src/admin/applications/wizard/methods/oauth/ak-application-wizard-authentication-by-oauth.ts # web/src/admin/applications/wizard/methods/proxy/AuthenticationByProxyPage.ts

gergosimonyi · 2024-09-04T15:11:10Z

Makefile

@@ -205,7 +205,7 @@ gen: gen-build gen-client-ts
 web-build: web-install  ## Build the Authentik UI
 	cd web && npm run build

-web: web-lint-fix web-lint web-check-compile web-test  ## Automatically fix formatting issues in the Authentik UI source code, lint the code, and compile it
+web: web-lint-fix web-lint web-check-compile  ## Automatically fix formatting issues in the Authentik UI source code, lint the code, and compile it


Accidental?

no this was the usual "unrelated" included thing

* main: web/admin: fix misc dual select on different forms (#11203) core: bump cryptography from 43.0.0 to 43.0.1 (#11185) ci: bump peter-evans/create-pull-request from 6 to 7 (#11186) core: bump goauthentik.io/api/v3 from 3.2024064.1 to 3.2024080.1 (#11187) core: bump django from 5.0.8 to 5.0.9 (#11188) core: bump watchdog from 5.0.1 to 5.0.2 (#11189) web: bump @sentry/browser from 8.27.0 to 8.28.0 in /web in the sentry group across 1 directory (#11191) web: bump yaml from 2.5.0 to 2.5.1 in /web (#11192) web: bump knip from 5.29.1 to 5.29.2 in /web (#11193) web: bump wireit from 0.14.8 to 0.14.9 in /web (#11194) web: bump @types/node from 22.5.2 to 22.5.3 in /web (#11195) root: backport s3 storage changes (#11181) core: fix change_user_type always requiring usernames (#11177) web/admin: fix error in Outpost creation form (#11173)

f0o · 2024-09-06T08:19:28Z

This didnt solve it fully - Providers are still unable to be created.

Browser Console yields:


ak-dual-select.ts:118 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'map')
    at h.willUpdate (ak-dual-select.ts:118:55)
    at h.performUpdate (reactive-element.ts:1439:14)
    at h.scheduleUpdate (reactive-element.ts:1338:25)
    at h._$ET (reactive-element.ts:1310:25)

ak-dual-select.ts:284 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'length')
    at h.render (ak-dual-select.ts:284:40)
    at h.update (lit-element.ts:158:24)
    at h.performUpdate (reactive-element.ts:1441:14)
    at h.scheduleUpdate (reactive-element.ts:1338:25)
    at h._$ET (reactive-element.ts:1310:25)

Image used:


REPOSITORY                   TAG         IMAGE ID       CREATED        SIZE
ghcr.io/goauthentik/server   2024.8.0    fdc41802befb   2 days ago     1.1GB

WasserEsser · 2024-09-06T20:45:22Z

@f0o it does for me.

The fix wasn't pushed live yet, it's available under a different repository.

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-version-2024.8

f0o · 2024-09-07T06:52:40Z

@WasserEsser Do you know when the patch will be feed into a release? I assumed it was cherry picked into the 2024.8 release 2 days ago.

Seems odd not to add this patch to the current release as it defacto breaks the whole functionality of it.

WasserEsser · 2024-09-07T11:10:09Z

@f0o it'll be included in 2024.8.1: #11209 (comment)

BeryJu added 7 commits September 4, 2024 12:55

fix prompt stage

89263d9

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix identification stage

b6981a2

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix OAuth JWKS sources

473eb60

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix oauth provider default scopes

834ed6c

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix outpost form

e904341

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix webauthn

b547b8f

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix transport form

f26d075

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu requested review from a team as code owners September 4, 2024 11:02

BeryJu merged commit 30fcdbf into main Sep 4, 2024
68 checks passed

BeryJu deleted the web/admin/fix-dual-select branch September 4, 2024 11:45

This was referenced Sep 4, 2024

Bug in "Passsword Change Prompt" #11205

Closed

Can't create OpenID Connect Provider #11179

Closed

gergosimonyi reviewed Sep 4, 2024

View reviewed changes

BeryJu mentioned this pull request Sep 4, 2024

Reworked prompt stage seems not functional #11209

Closed

WasserEsser mentioned this pull request Sep 7, 2024

Unable to create new Proxy Provider #11263

Closed

BeryJu mentioned this pull request Oct 31, 2024

Can't not create any providers #11190

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

web/admin: fix misc dual select on different forms #11203

web/admin: fix misc dual select on different forms #11203

BeryJu commented Sep 4, 2024

BeryJu commented Sep 4, 2024

netlify bot commented Sep 4, 2024 •

edited

Loading

netlify bot commented Sep 4, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024

gcp-cherry-pick-bot bot commented Sep 4, 2024

gergosimonyi Sep 4, 2024

BeryJu Sep 4, 2024

f0o commented Sep 6, 2024 •

edited

Loading

WasserEsser commented Sep 6, 2024

f0o commented Sep 7, 2024

WasserEsser commented Sep 7, 2024

web/admin: fix misc dual select on different forms #11203

web/admin: fix misc dual select on different forms #11203

Conversation

BeryJu commented Sep 4, 2024

Details

Checklist

BeryJu commented Sep 4, 2024

netlify bot commented Sep 4, 2024 • edited Loading

✅ Deploy Preview for authentik-storybook ready!

netlify bot commented Sep 4, 2024 • edited Loading

✅ Deploy Preview for authentik-docs canceled.

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 4, 2024

gcp-cherry-pick-bot bot commented Sep 4, 2024

gergosimonyi Sep 4, 2024

Choose a reason for hiding this comment

BeryJu Sep 4, 2024

Choose a reason for hiding this comment

f0o commented Sep 6, 2024 • edited Loading

WasserEsser commented Sep 6, 2024

f0o commented Sep 7, 2024

WasserEsser commented Sep 7, 2024

netlify bot commented Sep 4, 2024 •

edited

Loading

netlify bot commented Sep 4, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

f0o commented Sep 6, 2024 •

edited

Loading