Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: nextcloud: add SSE warning #11976

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

disconn3ct
Copy link
Contributor

Details

Nextcloud server-side encryption requires access to the user's plaintext password. This adds a warning to the integration doc.

Closes #11975

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Dis <397465+disconn3ct@users.noreply.github.com>
@disconn3ct disconn3ct requested a review from a team as a code owner November 9, 2024 12:30
Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 841eebf
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67339b3bf394330008419724

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 841eebf
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67339b3bb97cc8000885fea1
😎 Deploy Preview https://deploy-preview-11976--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


- [via OIDC Connect (OAuth)](#openid-connect-auth)
- [via SAML](#saml-auth)
- via LDAP outpost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are adding a third option here, we need to add a section below for it, like the other two. This new sectin could be quite short, just a sentence explaining the process conceptually, and link off to this doc: https://docs.goauthentik.io/docs/add-secure-apps/outposts/#more-about-outpost-integrations.

Or link to the separate docs for K9s vs Docker...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not trivial and I do not have a clean configuration to offer, much less a reasonable process. I thought the data loss warranted a notice. I am not agreeing to expand the scope of the volunteer work I am doing at this time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I can do it later, after we merge your addition! Thanks again for adding the important info.

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this. A suggestion and a few edits, please, then let's get it merged.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (9036724) to head (841eebf).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11976      +/-   ##
==========================================
- Coverage   92.64%   92.57%   -0.07%     
==========================================
  Files         761      761              
  Lines       37816    37841      +25     
==========================================
- Hits        35033    35032       -1     
- Misses       2783     2809      +26     
Flag Coverage Δ
e2e 49.19% <ø> (-0.02%) ⬇️
integration 24.91% <ø> (-0.01%) ⬇️
unit 90.15% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Dis <397465+disconn3ct@users.noreply.github.com>
@rissson rissson changed the title fix: docs: add sse warning to nextcloud website/integrations: nextcloud: add SSE warning Nov 12, 2024
Signed-off-by: Jens L. <jens@beryju.org>
@BeryJu BeryJu dismissed tanberry’s stale review November 12, 2024 18:16

changes adressed

@BeryJu BeryJu enabled auto-merge (squash) November 12, 2024 18:16
@BeryJu BeryJu merged commit 568d5c3 into goauthentik:main Nov 12, 2024
64 checks passed
kensternberg-authentik added a commit that referenced this pull request Nov 14, 2024
* main:
  providers/ldap: fix global search_full_directory permission not being sufficient (#12028)
  website/docs: 2024.10.2 release notes (#12025)
  lifecycle: fix ak exit status not being passed (#12024)
  core: use versioned_script for path only (#12003)
  core, web: update translations (#12020)
  core: bump google-api-python-client from 2.152.0 to 2.153.0 (#12021)
  providers/oauth2: fix manual device code entry (#12017)
  crypto: validate that generated certificate's name is unique (#12015)
  core, web: update translations (#12006)
  core: bump google-api-python-client from 2.151.0 to 2.152.0 (#12007)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#12011)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#12010)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#12012)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#12013)
  providers/proxy: fix Issuer when AUTHENTIK_HOST_BROWSER is set (#11968)
  website/docs: move S3 ad GeoIP to System Management/Operations (#11998)
  website/integrations: nextcloud: add SSE warning (#11976)
kensternberg-authentik added a commit that referenced this pull request Nov 14, 2024
* main:
  providers/ldap: fix global search_full_directory permission not being sufficient (#12028)
  website/docs: 2024.10.2 release notes (#12025)
  lifecycle: fix ak exit status not being passed (#12024)
  core: use versioned_script for path only (#12003)
  core, web: update translations (#12020)
  core: bump google-api-python-client from 2.152.0 to 2.153.0 (#12021)
  providers/oauth2: fix manual device code entry (#12017)
  crypto: validate that generated certificate's name is unique (#12015)
  core, web: update translations (#12006)
  core: bump google-api-python-client from 2.151.0 to 2.152.0 (#12007)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#12011)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#12010)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#12012)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#12013)
  providers/proxy: fix Issuer when AUTHENTIK_HOST_BROWSER is set (#11968)
  website/docs: move S3 ad GeoIP to System Management/Operations (#11998)
  website/integrations: nextcloud: add SSE warning (#11976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Nextcloud integration: warn about encryption app
3 participants