-
-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: applications: redirect user on application rename #11981
Changes from all commits
e96de6f
2c265e7
41a638b
f605cdc
0c1ba8c
6837d8e
8e739ac
5aed115
2a508df
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,6 +107,11 @@ export class ApplicationForm extends WithCapabilitiesConfig(ModelForm<Applicatio | |
}, | ||
}); | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should be doing both this and the change below in a more generic way for all objects that are identified by a user-configurable identifier cc @kensternberg-authentik There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kensternberg-authentik . Sorry to bother. Would it be possible to get a comment regarding this comment if possible? |
||
if (this.instance && this.instance.slug !== app.slug) { | ||
window.location.href = `#/core/applications/${app.slug}`; | ||
} | ||
|
||
return app; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is
session["redirect_to"]
used? This should not be required ideally, this should be purely handled in the frontend